Skip to content

Build against the final unitsml-rs delivery and replay the register scope vectors - #3

Merged
suleman-uzair merged 1 commit into
mainfrom
feat/final-deps-20261112
Nov 12, 2026
Merged

suleman-uzair merged 1 commit into
mainfrom
feat/final-deps-20261112

Conversation

@suleman-uzair

Copy link
Copy Markdown
Member

This PR moves the native pin in native-source.json and ci/native-source.json from unitsml/unitsml-rs fd3b3cb to the final delivery head 14c1707. That head includes 87c97eb: a caller registration now applies only to the unit the request names. Registering the pound no longer makes the US hundredweight convertible.

Changes

  • native-source.json: native source 14c1707, its Cargo.lock hash, unitsdb-rs 969a131 with its bundled UnitsDB b210137 data hash, and the library hash of a local 1.95.0 build. CI still validates the binary it builds through the build receipt.
  • ci/native-source.json: unitsdb-rs is now a locked Cargo git dependency of unitsml-rs, so the sibling checkout (checkout_as) is gone. The asciiunits and F40 corpus pins are unchanged.
  • tests/register-scope-vectors.json holds two new vectors recorded from unitsml-ruby 2ec9583 on UnitsDB b0b4315. Registering lb (NISTu201) converts 2 lb to 45359237/50000000 kg. With only the pound registered, cwt (US) (NISTu230) is refused with a ConversionError; the native code is missing_conversion.
  • tests/test_register_scope.py replays those vectors against the installed wheel. tests/f40-quantities.json and tests/test_installed.py are unchanged.

…cope vectors

The native pin moves from unitsml-rs fd3b3cb to 14c1707, which includes
87c97eb: a caller registration applies only to the unit the request names.
unitsml-rs now takes unitsdb-rs 969a131 (UnitsDB b210137, merged as b0b4315)
as a locked Cargo git dependency, so the sibling unitsdb-rs checkout is
dropped. native-source.json records the new commit, Cargo.lock, UnitsDB data
and library hashes; CI still validates the binary it builds through the
build receipt. The asciiunits and F40 corpus pins are unchanged.

tests/register-scope-vectors.json records two vectors from unitsml-ruby
2ec9583 on UnitsDB b0b4315: with the pound (NISTu201) registered, 2 lb
converts to 45359237/50000000 kg, and cwt (US) (NISTu230) is refused because
the pound has no UnitsDB conversion. tests/test_register_scope.py replays them
against the installed wheel; the F40 vectors are unchanged.
@suleman-uzair
suleman-uzair marked this pull request as ready for review November 12, 2026 13:18
@suleman-uzair
suleman-uzair merged commit 278a28d into main Nov 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant